[PATCH] D101821: [Demangle][Rust] Parse paths and named types
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 7 13:24:21 PDT 2021
dblaikie added a comment.
Could this be cut down further to be paths OR named types, rather than both? (I know this seems fussy/like a pain & I'm sorry about that - but if it gets down to the smallest thing possible (like adding only one named type and associated tests) I'm hoping it'll be super easy to review and verify the tests/understand how the grammar is implemented, etc - as it stands currently it does take me a while to understand each test case, which set of grammar rules are being tested relative to which different rules are being implemented in the patch, etc)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101821/new/
https://reviews.llvm.org/D101821
More information about the llvm-commits
mailing list