[PATCH] D101842: [flang][cmake] Enable the new driver by default

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 7 12:14:37 PDT 2021


Meinersbur accepted this revision.
Meinersbur added a comment.

In D101842#2744957 <https://reviews.llvm.org/D101842#2744957>, @MehdiChinoune wrote:

> You can use `set(LLVM_ENABLE_PROJECTS "${LLVM_ENABLE_PROJECTS}" "clang" CACHE STRING "list of projects to build" FORCE)`
> to force-update it.

This duplicates the option line with the setting description. Generally, I think user-controlled configuration parameters should stay user-controlled. Controlling the defaults for LLVM_TOOL_*_BUILD might be a better option.

I agree this would be matter of another patch to fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101842/new/

https://reviews.llvm.org/D101842



More information about the llvm-commits mailing list