[PATCH] D102038: [AArch64][GlobalISel] Create a new minimal combiner pass just for -O0.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/include/llvm/Target/GlobalISel/Combine.td:662
+
+def optnone_combines : GICombineGroup<[trivial_combines,
+    ptr_add_immed_chain, combines_for_extload,
----------------
At some point we should probably document the combiner groups.


================
Comment at: llvm/include/llvm/Target/GlobalISel/Combine.td:665
+    not_cmp_fold, opt_brcond_by_inverting_cond]>;
\ No newline at end of file

----------------
missing newline


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64O0PreLegalizerCombiner.cpp:40
+/// \returns true if \p MI was replaced with a G_BZERO.
+static bool tryEmitBZero(MachineInstr &MI, MachineIRBuilder &MIRBuilder,
+                         bool MinSize) {
----------------
This is still in the normal pre-legalizer combiner right?

Maybe we should factor the shared functions out into a separate file.


================
Comment at: llvm/test/CodeGen/AArch64/combine-loads.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc < %s -O0 -mtriple=aarch64-unknown-unknown | FileCheck %s
 
----------------
Maybe there should be a non-O0 checkline here too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102038/new/

https://reviews.llvm.org/D102038