[PATCH] D101996: [LLD] Improve reporting unresolved symbols in shared libraries

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 7 09:28:55 PDT 2021


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks great!



================
Comment at: lld/ELF/InputFiles.h:388
+  // Non-weak undefined symbols which are not yet resolved when the SO is
+  // parsed. Only filled if we check unresolved symbols in shared libraries,
+  // i.e. (config->unresolvedSymbolsInShlib != UnresolvedPolicy::Ignore).
----------------
MaskRay wrote:
> Perhaps simply this to `--no-allow-shlib-undefined`
Drop `and alike`? There is no other usage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101996/new/

https://reviews.llvm.org/D101996



More information about the llvm-commits mailing list