[PATCH] D101360: [PowerPC] Spilling to regsiters does not require frame index scavenging
Victor Huang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 7 09:04:25 PDT 2021
NeHuang added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:396
+ if (offsetMinAlignForOpcode(Opcode) > 1) {
+ LLVM_DEBUG(dbgs() << "Momory Operand: " << InstrInfo->getName(Opcode)
+ << " for register " << printReg(Reg, this) << ".\n");
----------------
nit typo: Momory -> Memory
Please also update the test cases.
================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:411
+ if (InstrInfo->isXFormMemOp(Opcode)) {
+ LLVM_DEBUG(dbgs() << "Momory Operand: " << InstrInfo->getName(Opcode)
+ << " for register " << printReg(Reg, this) << ".\n");
----------------
ditto
================
Comment at: llvm/test/CodeGen/PowerPC/frame_index_scavenging.mir:100
+# P8: requiresFrameIndexScavenging for SpillVR.
+# P8: Momory Operand: STVX for register $v20.
+# P8: TRUE - Memory operand is X-Form.
----------------
ditto
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101360/new/
https://reviews.llvm.org/D101360
More information about the llvm-commits
mailing list