[PATCH] D101900: [InstCombine] Fold extractelement + vector GEP with one use
David Sherwood via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 7 06:06:25 PDT 2021
david-arm marked 5 inline comments as done.
david-arm added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp:440
+ // Find out why we have a vector result - there are possibilities:
+ // 1. We have a scalar pointer and a vector of indices, or
+ // 2. We have a vector of pointers and a scalar index, or
----------------
sdesmalen wrote:
> Does this need to be limited to a vector of indices that is also a splat?
Sorry for not explaining this better in the previous commit message. I've tried to make it clear that I'm applying the fold unconditionall on the basis that in general a scalar GEP is still preferrable to a vector one.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101900/new/
https://reviews.llvm.org/D101900
More information about the llvm-commits
mailing list