[PATCH] D101842: [flang][cmake] Enable the new driver by default

Fri May 7 05:16:19 PDT 2021

awarzynski marked 2 inline comments as done.
awarzynski added inline comments.

================
Comment at: llvm/CMakeLists.txt:86
+    message(STATUS "Enabling Clang as a dependency to flang")
+    list(APPEND LLVM_ENABLE_PROJECTS "clang")
+  endif()
----------------
Meinersbur wrote:
> `CACHE` variables are user-controlled and should not be modified. Actually, this creates a new non-cached local variables that shadows the cached variable.
> 
> From the CMake manual:
> > Normally projects should avoid using normal and cache variables of thesame name, as this interaction can be hard to follow.  
> 
Thanks for pointing this out. It sounds like we shouldn't be touching `LLVM_ENABLE_PROJECTS` at all. 

We should also remove `list(APPEND LLVM_ENABLE_PROJECTS "mlir")`, but I'd rather send a separate patch for this. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101842/new/

https://reviews.llvm.org/D101842