[PATCH] D101312: [Utils] Do not remove comments in llc test script
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 7 02:37:16 PDT 2021
foad added inline comments.
================
Comment at: llvm/utils/UpdateTestChecks/common.py:265
self.attrs = attrs
- def is_same_except_arg_names(self, extrascrub, args_and_sig, attrs):
+ def is_same_except_arg_names(self, extrascrub, args_and_sig, attrs, is_asm):
arg_names = set()
----------------
It seems like most of the "arg name scrubbing" that this function does is not relevant for asm? Perhaps update_llc_test_checks could use a much much simpler form of this function instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101312/new/
https://reviews.llvm.org/D101312
More information about the llvm-commits
mailing list