[PATCH] D101247: [Debug-Info] strict dwarf for DW_OP_stack_value

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

In D101247#2717218 <https://reviews.llvm.org/D101247#2717218>, @dblaikie wrote:

> I think this fix is too narrow/special-cased. Other places where expressions are emitted might use DW_OP_stack_value (check out all the test cases in llvm/test that mention DW_OP_stack_value - I think they're not only from global variables) - so probably the solution is to have some abstraction for emitting a DwarfExpression into a block for an attribute (if we don't have one already) and have that abstraction scan the operations to see if there's a DW_OP_stack_value, and if there is, the attribute would be skipped. Also refactoring any emission of expressions to ensure they all use such an abstraction so they go through a common codepath.

Thanks, David, just back from a vacation. I will have a check if we can abstract some logic here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101247/new/

https://reviews.llvm.org/D101247