[PATCH] D101987: [DAG] Add a generic expansion for SHIFT_PARTS opcodes using funnel shifts

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

In D101987#2743959 <https://reviews.llvm.org/D101987#2743959>, @RKSimon wrote:

> In D101987#2742612 <https://reviews.llvm.org/D101987#2742612>, @efriedma wrote:
>
>> LGTM, but someone familiar with AMDGPU should look at those changes.
>
> @arsenm @foad Would you be willing to accept this?

I don't see anything that's obviously worse, and some cases like shift of an i64 constant by variable look significantly better, so OK.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101987/new/

https://reviews.llvm.org/D101987