[PATCH] D101997: [lld] Add a feature for each lld variant when use_lld is called

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/utils/lit/tests/Inputs/lld-features/lit.cfg:12-15
+lit.llvm.llvm_config.with_environment('LDLLD', os.path.join(curdir, 'tool1'))
+lit.llvm.llvm_config.with_environment('LLDLINK', os.path.join(curdir, 'tool2'))
+lit.llvm.llvm_config.with_environment('LD64LLD', os.path.join(curdir, 'tool3'))
+lit.llvm.llvm_config.with_environment('WASMLD', os.path.join(curdir, 'tool4'))
----------------
thopre wrote:
> This seems to be leaking from https://reviews.llvm.org/D101995
Not entirely sure what you mean by "leaking" here. I'm making use of the environment variable to ensure there's a real file being pointed at so that the features are enabled. Strictly, it's not required as there's no check for existence of the file specified by the environment variable, but that might change in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101997/new/

https://reviews.llvm.org/D101997