[PATCH] D101718: [X86] Fold load with tail call more aggressively
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 6 21:33:38 PDT 2021
pengfei added a comment.
I don't find any problem in the tests. So I think it looks good. But I'm not familiar with call lowering, I'd like others to sign off.
================
Comment at: llvm/test/CodeGen/X86/sibcall-4.ll:7
; CHECK-LABEL: t:
-; CHECK: jmpl *%eax
+; CHECK: jmpl *(%eax)
%nm3 = getelementptr i32, i32* %Sp_Arg, i32 1
----------------
Nit: This change is confusing. Maybe better to check all assemblys, or to use `update_llc_test_checks.py` to generate it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101718/new/
https://reviews.llvm.org/D101718
More information about the llvm-commits
mailing list