[PATCH] D99399: [elfabi] Prepare llvm-elfabi for elfabi/ifs merging.

[Haowei Wu via Phabricator via llvm-commits]

haowei added inline comments.


================
Comment at: llvm/lib/InterfaceStub/TBEHandler.cpp:61
+    if (Value == ELFEndiannessType::Unknown) {
+      return "Unsupported endianness";
+    }
----------------
phosek wrote:
> Does this trigger an error? If not we should maybe consider using an assertion.
Yes, there is a test case in tools/llvm-elfabi/read-tbe-with-bad-endianness.test , Since the data is from a yaml file, it's better to generate an error message instead of using assertion.


================
Comment at: llvm/lib/InterfaceStub/TBEHandler.cpp:90
+    if (Value == ELFBitWidthType::Unknown) {
+      return "Unsupported bit width";
+    }
----------------
phosek wrote:
> Ditto here.
there is a test case in tools/llvm-elfabi/read-tbe-with-bad-bitwidth.test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99399/new/

https://reviews.llvm.org/D99399