[PATCH] D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF.
EsmeYi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 6 19:41:15 PDT 2021
Esme added inline comments.
================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:350
+ // Write the string table.
+ Strings.write(W.OS);
+ }
----------------
jhenderson wrote:
> I don't know if this makes sense, but do we need a test case where there are no symbols, and therefore no string table?
The string table contains only long symbol names, so it's reasonable that there would be no string table without symbols.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100375/new/
https://reviews.llvm.org/D100375
More information about the llvm-commits
mailing list