[PATCH] D102038: [AArch64][GlobalISel] Create a new minimal combiner pass just for -O0.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 6 17:52:42 PDT 2021


aemerson created this revision.
aemerson added reviewers: paquette, arsenm.
aemerson added a project: LLVM.
Herald added subscribers: nikic, danielkiss, hiraditya, kristof.beyls, rovka, mgorny.
aemerson requested review of this revision.
Herald added a subscriber: wdng.

We never bothered to have a separate set of combines for -O0 in the prelegalizer before. This results in some minor performance hits for a mode where performance isn't a concern (although not regressing code size significantly is still preferable).

Through experiments, I've arrived at a set of combines that gets the most code size improvement at -O0, while reducing the amount of time spent in the combiner by around 25% give or take.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102038

Files:
  llvm/include/llvm/Target/GlobalISel/Combine.td
  llvm/lib/Target/AArch64/AArch64.h
  llvm/lib/Target/AArch64/AArch64Combine.td
  llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
  llvm/lib/Target/AArch64/CMakeLists.txt
  llvm/lib/Target/AArch64/GISel/AArch64O0PreLegalizerCombiner.cpp
  llvm/lib/Target/AArch64/GISel/AArch64PreLegalizerCombiner.cpp
  llvm/test/CodeGen/AArch64/O0-pipeline.ll
  llvm/test/CodeGen/AArch64/combine-loads.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102038.343545.patch
Type: text/x-patch
Size: 16492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210507/eda4d9f0/attachment.bin>


More information about the llvm-commits mailing list