[PATCH] D101446: [llvm] Improve export.sh with help and snapshot

Konrad Wilhelm Kleine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 6 15:22:07 PDT 2021


kwk updated this revision to Diff 343510.
kwk added a comment.

- Remove duplicate code


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101446/new/

https://reviews.llvm.org/D101446

Files:
  llvm/utils/release/export.sh


Index: llvm/utils/release/export.sh
===================================================================
--- llvm/utils/release/export.sh
+++ llvm/utils/release/export.sh
@@ -34,17 +34,18 @@
 Usage: $(basename $0) [-release|--release <major>.<minor>.<patch>]
                       [-rc|--rc <num>]
                       [-final|--final]
-                      [-snapshot|--snapshot <git-ref>] 
+                      [-git-ref|--git-ref <git-ref>] 
 
 Flags:
 
   -release  | --release <major>.<minor>.<patch>    The version number of the release
   -rc       | --rc <num>                           The release candidate number
   -final    | --final                              When provided, this option will disable the rc flag
-  -snapshot | --snapshot <git-ref>                 (optional) Use <git-ref> to determine the release and don't export the test-suite files
+  -git-ref  | --git-ref <git-ref>                  (optional) Use <git-ref> to determine the release and don't export the test-suite files
 
-These are the filenames (with <placeholders>) for the artifacts and hard
-links for each LLVM component created by this script: 
+The following list shows the filenames (with <placeholders>) for the artifacts and
+hard links for each LLVM component created by this script. Notice, the hard links
+are only created when you give --snapshot <git-ref>.
 
 $(\
       echo "$projects " \
@@ -75,12 +76,6 @@
 export_sources() {
     tag="llvmorg-$release"
 
-    if [ "$rc" = "final" ]; then
-        rc=""
-    else
-        tag="$tag-$rc"
-    fi
-
     llvm_src_dir=$(readlink -f $(dirname "$(readlink -f "$0")")/../../..)
     [ -d $llvm_src_dir/.git ] || ( echo "No git repository at $llvm_src_dir" ; exit 1 )
 
@@ -151,7 +146,7 @@
         -final | --final )
             rc="final"
             ;;
-        -snapshot | --snapshot )
+        -git-ref | --git-ref )
             shift
             snapshot="$1"
             ;;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101446.343510.patch
Type: text/x-patch
Size: 1944 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210506/cd55a845/attachment.bin>


More information about the llvm-commits mailing list