[PATCH] D101972: Do not set CMAKE_CXX_VISIBILITY_PRESET to hidden

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 6 14:58:15 PDT 2021


rnk added a comment.

In D101972#2743043 <https://reviews.llvm.org/D101972#2743043>, @tstellar wrote:

> @rnk Even if we were to commit this patch, do you think we would still need to fix/remove llvm:Any?

Yes, even if we commit this patch, it seems likely that someone would still run into these kinds of issues later. Passing an Any instance from one DLL to another and then attempting to cast wouldn't work, the ids will be different, and I don't think there is an easy way to fix it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101972/new/

https://reviews.llvm.org/D101972



More information about the llvm-commits mailing list