[PATCH] D101970: [X86FixupLEAs] Transform the sequence LEA/SUB to SUB/SUB

Thu May 6 09:59:44 PDT 2021

Carrot added inline comments.

================
Comment at: llvm/test/CodeGen/X86/lea-opt2.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-unknown | FileCheck %s
+
----------------
RKSimon wrote:
> I think its ok to pre-commit this (with a suitable extra FIXME/TODO explanation comment) and then rebase the patch to show the diffs.
Will do.

================
Comment at: llvm/test/CodeGen/X86/lea-opt2.ll:145
+  store i64 %1, i64* %p, align 8
+  %sub1 = sub nsw i64 %ld, %b
+  ret i64 %sub1
----------------
RKSimon wrote:
> are the nsw relevant?
It should not be relevant.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101970/new/

https://reviews.llvm.org/D101970