[PATCH] D101954: [lld-macho] Support loading of zippered dylibs

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 6 08:20:25 PDT 2021


int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.h:207
+template <class CommandType = llvm::MachO::load_command, class... Types>
+const std::vector<const CommandType *> findCommands(const void *anyHdr,
+                                                    Types... types) {
----------------
oontvoo wrote:
> It's a bit unfortunate that this function and the `findCommand` right above it are very similar ...
> could the other one be refactored to return zero, one, or more somehow?
> 
> 
fair point... done :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101954/new/

https://reviews.llvm.org/D101954



More information about the llvm-commits mailing list