[PATCH] D95339: [RFC][test] Adapt debug-info lit framework for more general purposes - part 1

Thu May 6 03:55:37 PDT 2021

jhenderson added a comment.

In D95339#2741545 <https://reviews.llvm.org/D95339#2741545>, @jhenderson wrote:

> I'm still looking at preventing the tools being picked up from the PATH.

I dug into this. The behaviour is not specific to the debuginfo-tests/cross-project-test testsuite. Rather, any tool that is found via use_llvm_tool will use this process. Primarily, this means any tool that calls use_clang/use_lld will fallback to the PATH version if none is found in the build directory. Looking back at the history, for clang this has been the behaviour for at least 12 years (see https://github.com/llvm/llvm-project/commit/be4253a0caf6f011b2af12803db9cf980f48084e), quite possibly longer. Changing the behaviour to no longer rely on the PATH could impact various tests beyond this testsuite, in clangd and lldb as well as in the clang and lld testsuites themselves.

I'm not convinced we need the behaviour to use the PATH version now. With the CLANG and LLDB environment variables allowing to override which tool is used, and a similar patch for LLD planned for later today, I think we can probably remove the functionality. I've posted https://lists.llvm.org/pipermail/llvm-dev/2021-May/150421.html to discuss this further. Either way, I think the decision that the email chain will hopefully lead to shouldn't hold up proceeding with this patch series. Could I therefore ask people to resume reivewing this series, please?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95339/new/

https://reviews.llvm.org/D95339