[PATCH] D101833: [AArch64][SVE] Fix missed immediate selection due to mishandling of signedness

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:3128
+        Shift = CurDAG->getTargetConstant(8, DL, MVT::i32);
+        Imm = CurDAG->getTargetConstant((ImmVal / 256) & 0xFF, DL, MVT::i32);
+        return true;
----------------
Suggestion: Use shift operation since this is about bit manipulation, and it's consistent with other uses nearby.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101833/new/

https://reviews.llvm.org/D101833