[PATCH] D101982: [debuginfo-tests] Allow use of environment variable to specify tools

Thu May 6 03:03:30 PDT 2021

jhenderson added a comment.

In D101982#2741492 <https://reviews.llvm.org/D101982#2741492>, @thopre wrote:

> Should we add a test for that?

We could add a lit test for the additional pass-through variables, if you think there's value in it (I don't think the other variables in the list are tested however), but I don't think we can test the lit.cfg.py change. To test that, we'd need to have a lit tests within the debuginfo-tests directory which spawns lit itself, with certain variables specified, and show that the right tools are used. I don't think this is practical. I've manually confirmed that the expected tools are used when the variables are set.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101982/new/

https://reviews.llvm.org/D101982