[PATCH] D101536: [SimplifyCFG] Common code sinking: drop profitability check in presence of conditional predecessors (PR30244)

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 6 01:49:06 PDT 2021


dvyukov added a comment.

> I was mainly talking about https://bugs.llvm.org/show_bug.cgi?id=30244#c1, the reproducible run-time slowdown.

Oh, I see, did not read that far.
Generally nobody looks at this level of detail, so for anything that does not lead to loud runtime crashes, it can well take 10 years for somebody to detect and report a new bug. Relying on that is not sound strategy :)

I don't have time to redo that test right now. But again I trust your results ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101536/new/

https://reviews.llvm.org/D101536



More information about the llvm-commits mailing list