[PATCH] D101954: [lld-macho] Support loading of zippered dylibs

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 20:05:50 PDT 2021


oontvoo accepted this revision.
oontvoo added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/MachO/InputFiles.h:207
+template <class CommandType = llvm::MachO::load_command, class... Types>
+const std::vector<const CommandType *> findCommands(const void *anyHdr,
+                                                    Types... types) {
----------------
It's a bit unfortunate that this function and the `findCommand` right above it are very similar ...
could the other one be refactored to return zero, one, or more somehow?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101954/new/

https://reviews.llvm.org/D101954



More information about the llvm-commits mailing list