[PATCH] D101410: [M68k][test] Initial migration of MC tests

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 17:52:03 PDT 2021


myhsu added inline comments.


================
Comment at: llvm/test/MC/M68k/Arith/Classes/MxNEG.s:4
+; CHECK-LABEL: MxNEG:
+MxNEG:
+	; CHECK:      neg.b  %d0
----------------
myhsu wrote:
> jrtc27 wrote:
> > myhsu wrote:
> > > jrtc27 wrote:
> > > > This file was committed with labels still
> > > The labels here are used to group different categories of instructions, such that we can isolate failure in a finer granularity. Therefore in the last changes I only clean up files with only a single label.
> > That is entirely unnecessary. Other targets don't do this. Labels are only added when you need an actual label.
> okay, I will fix it shortly
Fixed in https://reviews.llvm.org/rGf6d7fc801b4a513a5d5e04762e0e4c71414ae5ef


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101410/new/

https://reviews.llvm.org/D101410



More information about the llvm-commits mailing list