[PATCH] D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 17:19:16 PDT 2021


StephenTozer added a comment.

In D101523#2739537 <https://reviews.llvm.org/D101523#2739537>, @dblaikie wrote:

> Might it be more suitable to move the test to the DebugInfo/ARM directory - which I think implicitly has such a requirement?

This is something I considered before updating; I believed that it would be better in the generic folder, because the test isn't about anything actually specific to ARM, we only need the ARM target for the current reproducer. Making it require ARM is the easiest solution, and if that means it should be in the ARM directory then I'm fine to move it there - although the ideal solution in that case would probably be to find a reproducer that doesn't depend on using ARM as the target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101523/new/

https://reviews.llvm.org/D101523



More information about the llvm-commits mailing list