[PATCH] D101817: [MC][X86] Automatic alignment for Macro-Op Fusion
Amir Ayupov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 5 16:44:38 PDT 2021
Amir marked an inline comment as done.
Amir added inline comments.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:364-366
+ AlignBranchIndirect = 1U << 5,
+ AlignMacroFusionCmp = 1U << 6,
+ AlignMacroFusionBranch = 1U << 7
----------------
skan wrote:
> The extension is definitely wrong. BranchFused indicates fused macro fusion pairs, why do you add something like "AlignMacroFusionCmp, AlignMacroFusionBranch" .
I wanted to avoid overloading the existing types with different actions based on them: ie JCC erratum would have used existing BranchBoundaryKinds, while auto MF alignment would use new ones. But I guess it's OK to reuse and make the action depend on a cl opt.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101817/new/
https://reviews.llvm.org/D101817
More information about the llvm-commits
mailing list