[PATCH] D101806: [TargetLowering] Only inspect attributes in the arguments for ArgListEntry
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 5 14:49:57 PDT 2021
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Skimming through the test cases, they all look like human written IR where the author forgot to put the attribute on the call site.
There is a risk that this could break a frontend that doesn't place ABI attributes on the call site. I think the new behavior is right, but go ahead and add something to llvm/docs/ReleaseNotes.rst to document the behavior change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101806/new/
https://reviews.llvm.org/D101806
More information about the llvm-commits
mailing list