[PATCH] D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors.

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 14:40:47 PDT 2021


oontvoo marked 2 inline comments as done.
oontvoo added inline comments.


================
Comment at: lld/test/MachO/invalid/incompatible-arch.s:45
+# RUN:	-o /dev/null 2>&1 | FileCheck %s --check-prefix=CROSS-SIM2
+# CROSS-SIM2: {{.*}}test_x86_ios_sim.o has platform iOS, which is different from target platform watchOS Simulator
+	
----------------
int3 wrote:
> why doesn't this say "iOS simulator"?
It seems the "simulator" part was removed by llvm-mc. (Running `otool` on test_x86_ios_sim.oshows that it's only "IOS" and not IOS-simulator


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101855/new/

https://reviews.llvm.org/D101855



More information about the llvm-commits mailing list