[PATCH] D101829: [SCEV] By more careful when traversing phis in isImpliedViaMerge.
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 5 14:20:48 PDT 2021
nikic added a comment.
What BasicAA does for this case is a CFG reachability check from the phi to the value. If it's reachable, you have some kind of cycle. I think what you're doing here is fine though, as this doesn't seem like a terribly important optimization to me, and the nature of SCEV makes those properlyDominates() checks likely to succeed for common cases (as non-SCEVUnknown expressions are effectively hoisted).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101829/new/
https://reviews.llvm.org/D101829
More information about the llvm-commits
mailing list