[PATCH] D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour accepted this revision.
bmahjour added a comment.
This revision is now accepted and ready to land.

So if I understand correctly, we still allow code in the exit block and the other target of the guard branch like before, so this is purely an improvement over what we had before. Although, as I said before I think we should allow non-empty blocks as well, but that can come as future extensions.



================
Comment at: llvm/include/llvm/Analysis/LoopNestAnalysis.h:65
+  /// (if there are any). When \p CheckUniquePred is set to true, check if
+  /// each of the empty single successors has an unique predecessor. Return
+  /// the last basic block found or \p End if it was reached during the search.
----------------
[nit] has an unique -> has a unique


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94717/new/

https://reviews.llvm.org/D94717