[PATCH] D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

Thanks for the updates! LGTM



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-reduction-inloop.ll:41
+
+.lr.ph:                                           ; preds = %entry, %.lr.ph
+  %indvars.iv = phi i32 [ %indvars.iv.next, %.lr.ph ], [ 0, %entry ]
----------------
CarolineConcatto wrote:
> fhahn wrote:
> > might be helpful to use a nicer name for the loop block to make the test a bit easier to parse, maybe `%loop`? Same for `._crit_edge`, perhaps `%exit`?
> Hey @fhahn thank you for your input,
> I  have changed .lr.ph to loop and ._crit_edge to exit.
> But just for reference, this test has the same llvm-ir as in reduction-inloop.ll but now using scalable vectors instead of fixed vector.
Thanks for improving it!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101260/new/

https://reviews.llvm.org/D101260