[PATCH] D101936: [hwasan] Stress test for thread creation.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 13:17:59 PDT 2021


hctim accepted this revision.
hctim added a comment.
This revision is now accepted and ready to land.

LGTM w/ nits



================
Comment at: compiler-rt/test/hwasan/TestCases/Linux/create-thread-stress.cpp:2
+// RUN: %clangxx_hwasan -DREUSE=0 %s -pthread -O2 -o %t && %run %t 2>&1
+// RUN: %clangxx_hwasan -DREUSE=1 %s -pthread -O2 -o %t_reuse && %run %t_reuse 2>&1
+
----------------
Can you leave a comment pointing to D101881 for posterity?


================
Comment at: compiler-rt/test/hwasan/TestCases/Linux/create-thread-stress.cpp:59
+  }
+#endif
+}
----------------
missing `return 0;` from main for non-reuse non-failure mode and reuse mode


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101936/new/

https://reviews.llvm.org/D101936



More information about the llvm-commits mailing list