[PATCH] D101894: [llvm-dwp] Add support for rnglists and loclists

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds OK - test might be able to be simplified a bit.



================
Comment at: llvm/test/tools/llvm-dwp/X86/loclists.s:25-30
+.Lfunc_begin0:
+  .space 4
+.Ltmp0:
+  .space 4
+.Ltmp1:
+.Lfunc_end0:
----------------
No need for actual .text in these files - these files are only dwo files, so they can have arbitrary hardcoded constants for the starting/ending offsets.


================
Comment at: llvm/test/tools/llvm-dwp/X86/rnglists.s:62-76
+	.asciz	"y_"                            # string offset=9
+	.section	.debug_abbrev.dwo,"e", at progbits
+	.byte	1                              # Abbreviation Code
+	.byte	17                              # DW_TAG_compile_unit
+	.byte	1                               # DW_CHILDREN_yes
+	.byte	37                              # DW_AT_producer
+	.byte	37                              # DW_FORM_strx1
----------------
Strange to have a complicated abbreviation that's not actually used - maybe if this abbrev was simplified to compile_unit, CHILDREN_no, with no attributes - then the TU/CU could be a bit more valid by only including that one DIE without any attributes/children - rather than missing their unit DIE entirely.

(I guess this was tested this way because something in llvm-dwp ended up requiring that the CU had a valid DIE? Maybe we could fix that so there's no need for there to be that empty/degenerate DIE in the CU? (so it can 'work' the same as the TU - without any DIEs at all))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101894/new/

https://reviews.llvm.org/D101894