[PATCH] D101224: [lld-macho] Have --reproduce account for path rerooting

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 11:40:26 PDT 2021


int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/test/MachO/reroot-path.s:28
+# RUN: tar xf %t/repro1.tar -C %t
+# RUN: cd %t/repro1; ld64.lld @response.txt | FileCheck %s -DDIR="%:t/%:t"
+
----------------
oontvoo wrote:
> should this be %lld (or some other pre-set param) to ensure  we're testing the "right" ld64.ldd? 
> (In theory, the machine could already have ld64.lld)
I think llvm-lit will ensure these paths map to the right things. If you run `llvm-lit -vva` you can see that this line invokes ld64.lld via an absolute path. (Same with other tools like llvm-objdump`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101224/new/

https://reviews.llvm.org/D101224



More information about the llvm-commits mailing list