[PATCH] D101284: [docs] Update the llvm/example section

PoojaYadav via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 09:43:14 PDT 2021


pooja2299 added a comment.

In D101284#2739176 <https://reviews.llvm.org/D101284#2739176>, @reames wrote:

> In D101284#2739148 <https://reviews.llvm.org/D101284#2739148>, @pooja2299 wrote:
>
>> In D101284#2739140 <https://reviews.llvm.org/D101284#2739140>, @reames wrote:
>>
>>> In D101284#2738040 <https://reviews.llvm.org/D101284#2738040>, @pooja2299 wrote:
>>>
>>>> @fhahn and @reames can you please review this patch?
>>>
>>> I have already given an LGTM, what more are you expecting?
>>
>> I meant after the changes that you asked .  
>> Thanks a lot 😄 👍
>
> Ah, sorry, I'm so used to LLVM phrasing that I forgot "LGTM w/minor optional comments" isn't widely understood.  For us, that generally means you can land with the changes made (if you decide to) without further review.

Oh ok 👍 I will remember this next time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101284/new/

https://reviews.llvm.org/D101284



More information about the llvm-commits mailing list