[PATCH] D101898: [ARM] Prevent spilling between ldrex/strex pairs

LemonBoy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 07:08:11 PDT 2021


LemonBoy added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1582
             .addReg(DesiredReg, RegState::Kill);
-    if (!IsThumb)
-      MIB.addImm(0);
+    MIB.addImm(0); // A1/T2 rotate operand
     MIB.add(predOps(ARMCC::AL));
----------------
Nit, guard this line with `if (UxtOp == t2UXTB)` as already done for the ldrex/strex ops below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101898/new/

https://reviews.llvm.org/D101898



More information about the llvm-commits mailing list