[PATCH] D90170: [InstCombine] InstCombinerImpl::visitOr - enable bitreverse matching

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 06:59:31 PDT 2021


RKSimon updated this revision to Diff 343032.
RKSimon retitled this revision from "[InstCombine] InstCombinerImpl::visitOr - enable limited bitreverse matching" to "[InstCombine] InstCombinerImpl::visitOr - enable bitreverse matching".
RKSimon edited the summary of this revision.
RKSimon added a comment.

Based on feedback (@nikic Are those timings still representable?) and my own local testing, I'm not seeing any really bad slow downs due to matching for bitreverse patterns as well as as byteswaps, so I've updated the patch without any i16 limitation.

If we're happy with this I think we can then remove the bitreverse matching entirely from codegenprepare.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90170/new/

https://reviews.llvm.org/D90170

Files:
  llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
  llvm/test/Transforms/InstCombine/bitreverse.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90170.343032.patch
Type: text/x-patch
Size: 8028 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210505/ef780f72/attachment.bin>


More information about the llvm-commits mailing list