[PATCH] D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST
Jeremy Morse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 5 06:07:33 PDT 2021
jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.
This LGTM modulo one inline comment, plus: the test is in the "Generic" directory, but it is not fully generic. It depends on the armv6 triple being supported, so things like the powerpc build bots will likely trip on it. You should add an appropriate REQUIRES line.
================
Comment at: llvm/test/DebugInfo/Generic/machine-cp-updates-dbg-reg.mir:4
+## Ensure that when the destination register of a copy instruction is used by a
+## DBG_VALUE/DBG_VALUE_LIST, and then that instruction is deleted during copy
+## propagation, the debug use is updated to the source register.
----------------
"then" -> "when" :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101523/new/
https://reviews.llvm.org/D101523
More information about the llvm-commits
mailing list