[PATCH] D99572: [AArch64] [COFF] Properly produce cross-section relative relocations

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 5 05:24:57 PDT 2021


mstorsjo added a comment.

In D99572#2738593 <https://reviews.llvm.org/D99572#2738593>, @thakis wrote:

> Sounds like the commit that turned this on by default broke Edge on win/arm64: https://bugs.chromium.org/p/chromium/issues/detail?id=1204788
>
> I'm guessing we'll get a standalone repro for that in time, but to save others time tracking down the bug from the enablement, maybe you want to undo it for now?
>
> (Not this change here, but https://github.com/llvm/llvm-project/commit/57b259a852a6383880f5d0875d848420bb3c2945 )

Ok, reverted it for now. I'd be interested to hear once you're able to pin down the issue closer, whether it's an issue with the relative relocations themselves, or with the rewrite done by the pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99572/new/

https://reviews.llvm.org/D99572



More information about the llvm-commits mailing list