[PATCH] D101536: [SimplifyCFG] Common code sinking: drop profitability check in presence of conditional predecessors (PR30244)

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 4 23:38:30 PDT 2021


dvyukov added a comment.

In D101536#2737140 <https://reviews.llvm.org/D101536#2737140>, @lebedev.ri wrote:

> @dvyukov Hi! Would it please be possible for you to redo the two-stage reproduction process
> you stated in https://bugs.llvm.org/show_bug.cgi?id=30244
> to double-check that i'm not simply doing it wrong, and the issue is/isn't there still?

I trust you to re-do the check. It's not that I can do it better or would trust myself 5 years later :)
I see you added some unit tests, so that should be good enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101536/new/

https://reviews.llvm.org/D101536



More information about the llvm-commits mailing list