[PATCH] D101806: [TargetLowering] Only inspect attributes in the arguments for ArgListEntry

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 4 16:42:02 PDT 2021


aeubanks added a comment.

In D101806#2736798 <https://reviews.llvm.org/D101806#2736798>, @rnk wrote:

> There are also two other ISel implementations to consider, perhaps they have the same bug: fastisel and globalisel. I think it's worth a quick code search.
>
> I think it's also reasonable to add a dedicated test for this. Calling a function with a mismatched prototype is UB, so the compiler is probably entitled to generate arbitrary code (trap), but it should generate something. The example I provided in the other code review is a good starting point.

fastisel also uses ArgListEntry.
globalisel looks like it has the same issue in CallLowering::getAttributesForArgIdx().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101806/new/

https://reviews.llvm.org/D101806



More information about the llvm-commits mailing list