[PATCH] D101847: [AMDGPU] Fix function pointer argument bug in AMDGPU Propagate Attributes pass.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 4 16:37:56 PDT 2021


jdoerfert added a comment.

Drive by only



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp:253
+        if (!CI || CI->getCalledFunction() != &F)
           continue;
         Function *Caller = CI->getCaller();
----------------
The usual way to deal with this is `bool CallBase::isCallee(const Use *U)`. It might make a difference if you have `foo(&foo)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101847/new/

https://reviews.llvm.org/D101847



More information about the llvm-commits mailing list