[PATCH] D101806: [TargetLowering] Only inspect attributes in the arguments for ArgListEntry

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: jdoerfert.
rnk added a comment.

In D101806#2737425 <https://reviews.llvm.org/D101806#2737425>, @dblaikie wrote:

> Naively, I'd wonder if/why `paramHasAttr` should be changed to look at the type of the call entirely - but I guess I have to wrap my head around ABI and non-ABI attributes - though I thought sret was an ABI attribute (I thought it specified something about how return values are passed), for instance.

I agree, sret is an ABI attribute. :)

I think the current `paramHasAttr` behavior is designed to help optimization passes, not codegen lowering passes. However, I'm not sure how helpful this really is, and we should consider revisiting it.

@jdoerfert, in your experience, is this `CallBase::paramhasAttr` behavior useful or harmful for optimizations?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101806/new/

https://reviews.llvm.org/D101806