[PATCH] D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'

Mike Rice via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 4 16:02:32 PDT 2021


mikerice added inline comments.


================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:1406-1413
+  do {
+    if (parseOMPDeclareVariantAnyClause(Loc, TI, ParentTI, AdjustNothing,
+                                        AdjustNeedDevicePtr))
+      return;
+    // Skip ',' if any.
+    if (Tok.is(tok::comma))
+      ConsumeToken();
----------------
ABataev wrote:
> Maybe turn it into `while {}` form? What if the clause is early terminated?
Rewrote this to parse the clauses in the loop here instead of the separate function, which seems better now that there is more than one clause possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99905/new/

https://reviews.llvm.org/D99905



More information about the llvm-commits mailing list