[PATCH] D98509: [LV] Calculate max feasible scalable VF.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

In D98509#2736263 <https://reviews.llvm.org/D98509#2736263>, @sdesmalen wrote:

> In D98509#2732628 <https://reviews.llvm.org/D98509#2732628>, @hubert.reinterpretcast wrote:
>
>> I haven't reached the root cause yet, but it appears that the issue we're hitting can be avoided if the `MaxSafeVF` parameter is made pass-by-reference instead of pass-by-value.
>> @sdesmalen, I hope the following is not too intrusive a change to your patch.
>
> Hi @hubert.reinterpretcast, thanks for your investigation so far! I have gone through the code several times, but don't really understand why your suggestion fixes the issue. I've also built it with both GCC and Clang, with- and without sanitizers, and with valgrind.

Thanks for looking into this from your end. I feel terrible that I wasn't more clear that a build compiler issue is looking to be likely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98509/new/

https://reviews.llvm.org/D98509