[PATCH] D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors.

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 4 15:10:35 PDT 2021


oontvoo marked 2 inline comments as done.
oontvoo added inline comments.


================
Comment at: lld/test/MachO/invalid/incompatible-arch.s:34
+## Test that simulators platforms are compat with their simulatees.		
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-ios10.15.0 %s -o %t/test_x86_ios.o
+
----------------
**Question**: I've tried to make `llvm-mc` produce an obj file(*)  with ios-simulator (or watchos-simulator) platform but it ended up producing files without any platform info.

(*) command used: `llvm-mc -filetype=obj -triple=x86_64-apple-iossimulator10.15.0 %s -o %t/test_x86_ios_sim.o`

Any idea what I got wrong?


(not super important for this patch , but would be nice to be able to test that an obj file with simulator-platform won't trigger an error against a "real" platform)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101855/new/

https://reviews.llvm.org/D101855



More information about the llvm-commits mailing list