[PATCH] D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors.

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

this needs a test :)



================
Comment at: lld/MachO/InputFiles.cpp:144
+  // Mapping of platform to simulator and vice-versa.
+  static std::map<PlatformKind, PlatformKind> *platformMap = []() {
+    auto *ret = new std::map<PlatformKind, PlatformKind>();
----------------
nit 1: for uniformity, can we use a DenseMap instead of a std::map? I know perf isn't important here but it would be nice to avoid std::map where possible

nit 2: I'm pretty sure we can initialize this via initializer lists rather than a lambda, i.e. something like

```
platformMap = {{PlatformKind::iOS, PlatformKind::iOSSimulator}, {PlatformKind::iOS, PlatformKind::iOSSimulator}, ...};
```


================
Comment at: lld/MachO/InputFiles.cpp:167
     return true;
   // TODO: Correctly detect simulator platforms or relax this check.
+  if (config->platform() != platformInfo->target.Platform &&
----------------
rm?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101855/new/

https://reviews.llvm.org/D101855