[PATCH] D98103: [NPM] Do not run function simplification pipeline unnecessarily

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked an inline comment as done.
mtrofin added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1033
+    FSP.addPass(RequireAnalysisPass<FunctionStatusAnalysis, Function>());
+  MainCGPipeline.addPass(createCGSCCToFunctionPassAdaptor(std::move(FSP)));
 
----------------
aeubanks wrote:
> mtrofin wrote:
> > aeubanks wrote:
> > > do we need to add a pass to invalidate FunctionStatusAnalysis after the inliner pipeline so that CGSCC pipelines after the inliner pipeline aren't skipped?
> > done
> We already have `InvalidateAnalysisPass<FunctionStatusAnalysis>` for that.
> It'd be nice if we could add it inside `buildInlinerPipeline()` since it's logically part of the inliner pipeline, but we only use it in one place so maybe it doesn't matter so much
done for the InvalidateAnalysisPass, thanks for pointing it out!

I want to rationalize a bit better things in the module inliner wrapper pass, so the invalidation of the status analysis should fall in in that patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98103/new/

https://reviews.llvm.org/D98103