[PATCH] D98103: [NPM] Do not run function simplification pipeline unnecessarily

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1033
+    FSP.addPass(RequireAnalysisPass<FunctionStatusAnalysis, Function>());
+  MainCGPipeline.addPass(createCGSCCToFunctionPassAdaptor(std::move(FSP)));
 
----------------
mtrofin wrote:
> aeubanks wrote:
> > do we need to add a pass to invalidate FunctionStatusAnalysis after the inliner pipeline so that CGSCC pipelines after the inliner pipeline aren't skipped?
> done
We already have `InvalidateAnalysisPass<FunctionStatusAnalysis>` for that.
It'd be nice if we could add it inside `buildInlinerPipeline()` since it's logically part of the inliner pipeline, but we only use it in one place so maybe it doesn't matter so much


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98103/new/

https://reviews.llvm.org/D98103